Skip to content

Update arrow, pyo3, and numpy#8618

Closed
emilk wants to merge 2 commits intomainfrom
emilk/arrow-54
Closed

Update arrow, pyo3, and numpy#8618
emilk wants to merge 2 commits intomainfrom
emilk/arrow-54

Conversation

@emilk
Copy link
Copy Markdown
Member

@emilk emilk commented Jan 8, 2025

There were a few scary changes to rerun_py/src/dataframe.rs - do we have automated testing for that?

@emilk emilk added dependencies concerning crates, pip packages etc exclude from changelog PRs with this won't show up in CHANGELOG.md 🏹 arrow Apache Arrow labels Jan 8, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 8, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
a1837c6 https://rerun.io/viewer/pr/8618 +nightly +main

Note: This comment is updated whenever you push a commit.

@emilk emilk marked this pull request as ready for review January 8, 2025 19:59
@emilk emilk requested a review from jleibs January 8, 2025 20:00
@emilk emilk added the do-not-merge Do not merge this PR label Jan 8, 2025
@jleibs
Copy link
Copy Markdown
Contributor

jleibs commented Jan 8, 2025

There were a few scary changes to rerun_py/src/dataframe.rs - do we have automated testing for that?

Not totally comprehensive, but there's partial coverage in: https://github.com/rerun-io/rerun/blob/71215dbc5e75ab476077ad203350da4ef7a2d793/rerun_py/tests/unit/test_dataframe.py

@emilk emilk added the blocked can't make progress right now label Jan 9, 2025
@emilk emilk marked this pull request as draft January 9, 2025 09:16
emilk added a commit that referenced this pull request Jan 9, 2025
* Part of #3741
* Requires rerun-io/re_arrow2#15

NOTE: this will regress on memory use, because we lack `.shrink_to_fit`,
which will arrive in
* #8618
@emilk
Copy link
Copy Markdown
Member Author

emilk commented Mar 20, 2025

@emilk emilk closed this Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏹 arrow Apache Arrow blocked can't make progress right now dependencies concerning crates, pip packages etc do-not-merge Do not merge this PR exclude from changelog PRs with this won't show up in CHANGELOG.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants