Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter entities in the UI (part 4): Add entity filtering in the blueprint tree #8706

Merged
merged 14 commits into from
Jan 20, 2025

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Jan 16, 2025

Related

What

This PR implements entity filtering in the blueprint tree.

In important design principle applied here is that the filtering applies only on the visible part of items. This has two major consequence:

  • The prefix of the data result entity path that matches the view origin is not considered in matching, because it is also not displayed in the tree. (That applies to non-projected data results.)
  • The sub-tree defined by the view origin is ignored when matching projected entities, because that sub-tree is not displayed either ($origin placeholder in the tree).

Snapshot tests for this is coming in the next PR

blueprint-tree-filter.mp4

@abey79 abey79 added ui concerns graphical user interface include in changelog labels Jan 16, 2025
Copy link

github-actions bot commented Jan 16, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
ff14c1d https://rerun.io/viewer/pr/8706 +nightly +main

Note: This comment is updated whenever you push a commit.

@abey79 abey79 force-pushed the antoine/filt4-blueprint-tree-filter branch 2 times, most recently from ba28745 to af41caf Compare January 16, 2025 17:59
@abey79 abey79 marked this pull request as ready for review January 16, 2025 18:01
@abey79 abey79 force-pushed the antoine/filt4-blueprint-tree-filter branch 2 times, most recently from 8e97d10 to df8dd4e Compare January 17, 2025 16:15
@Wumpf Wumpf self-requested a review January 20, 2025 09:25
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking great, love those new tests as well
the nˆ2 behavior in the search is a bit concerning but we talked about this already (more refactors following which may be able to address this along the way)

crates/viewer/re_context_menu/src/collapse_expand.rs Outdated Show resolved Hide resolved
@abey79 abey79 force-pushed the antoine/filt4-blueprint-tree-filter branch from fd3a9ee to ff14c1d Compare January 20, 2025 15:36
@abey79 abey79 merged commit a0f2cf2 into main Jan 20, 2025
31 checks passed
@abey79 abey79 deleted the antoine/filt4-blueprint-tree-filter branch January 20, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants