-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter entities in the UI (part 4): Add entity filtering in the blueprint tree #8706
Conversation
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
ba28745
to
af41caf
Compare
8e97d10
to
df8dd4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking great, love those new tests as well
the nˆ2 behavior in the search is a bit concerning but we talked about this already (more refactors following which may be able to address this along the way)
…d/added tests for streams
Also: updated/added tree walking apis for `DataResultTree` and `ViewportBlueprint` Two problems: - matches `$origin` when it shouldn't - matches in-origin-tree entities for parts that are _above or at_ origin Both of these are not displayed, and thus should not be matched.
… when there are none
fd3a9ee
to
ff14c1d
Compare
Related
CustomContent
more useful #8645What
This PR implements entity filtering in the blueprint tree.
In important design principle applied here is that the filtering applies only on the visible part of items. This has two major consequence:
$origin
placeholder in the tree).Snapshot tests for this is coming in the next PR
blueprint-tree-filter.mp4