ci: Deploy to Cloudflare using a Github Action #1159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderochervlk
force-pushed
the
vlk/cloudflare-workers
branch
from
7ed801e to
0273917
Compare
Deploying rescript-lang-org with
|
| Latest commit: |
4601f43
|
| Status: | 🚫 Build failed. |
jderochervlk
changed the title
cometkim
reviewed
Dec 17, 2025
Member
cometkim
left a comment
cometkim
left a comment
There was a problem hiding this comment.
Deploying via actions is good.
It would be helpful to migrate the pages project to a workers project immediately afterward.
The @cloudflare/pages-plugin-vercel-og project provides excellent support for dynamic OG using a combination of Satori and HTMLRewriter. Also, a change to the CDN cache configuration is required to reduce unnecessary function calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches builds over from being configured in the Cloudfront dashboard to a Github action, which means it's now Infrastructure as Code. We can now also use a Github action to manually fire off a build, which is nice. Having this happen on a Github action will give us access to the deployment URL, which will be needed if we want to setup Playwright or Chromatic for automated testing (which would be great!).
This also tested out an example Cloudflare function, which you can see at https://d0b34a60.rescript-lang.pages.dev/echo?foo=bar. This doesn't mean that the app is using SSR, but Cloudflare pages can still have access to functions, which I plan on using to create dynamic open graph images. The function has been removed after testing. I wanted to make sure that Cloudflare could handle
.jsxfiles.This also changes some of the commands used for builds and development to simplify things. Now you can run
yarn devto kick off concurrent builds for ReScript, Vite, and Wrangler (which will be used to develop functions locally).The existing Cloudflare job is expected to fail and will need to be removed alongside of merging in this PR (probably right before).