Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax lookup: labeled and optional args #888

Merged
merged 5 commits into from
Jun 28, 2024

Conversation

fhammerschmidt
Copy link
Member

No description provided.

@fhammerschmidt fhammerschmidt requested review from cknitt, ryyppy and zth June 14, 2024 21:46
Copy link

vercel bot commented Jun 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rescript-lang.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2024 1:28pm

@fhammerschmidt fhammerschmidt changed the title Syntax lookup labeled ad optional args Syntax lookup labeled and optional args Jun 14, 2024
@fhammerschmidt fhammerschmidt changed the title Syntax lookup labeled and optional args Syntax lookup: labeled and optional args Jun 14, 2024
@aspeddro
Copy link
Collaborator

Can you add the @tag attribute?

https://rescript-lang.org/docs/manual/latest/variant#tagged-variants

@fhammerschmidt
Copy link
Member Author

Will do, but in another PR. Added to the list for now.

Copy link
Collaborator

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 2 small comments from me, not sure if they're relevant in the syntax lookup though.

@fhammerschmidt fhammerschmidt merged commit cc5fbee into master Jun 28, 2024
3 checks passed
@fhammerschmidt fhammerschmidt deleted the syntax-lookup-labeled-args branch June 28, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants