Use fs api to check if string is a directory. #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @zth |
zth
requested changes
Mar 28, 2025
server/src/utils.ts
Outdated
Comment on lines
70
to
71
| const isDir = path.extname(source) === ""; | ||
| const dirStat = fs.statSync(source); | ||
| const isDir = dirStat.isDirectory(); |
There was a problem hiding this comment.
IIRC, this is in a hot path where we shouldn't use fs functions (which is why this fn looks the way it looks now). So we need to figure out another way to do this, outside of the hot path. OTOH maybe it could be aggressively cached in some sane way (unlikely), or moved outside of the hot path entirely to some sort of setup function somewhere. Would need to be explored.
nojaf
commented
Mar 28, 2025
| @@ -268,7 +268,7 @@ let openedFile = (fileUri: string, fileContent: string) => { | |||
| filesDiagnostics: {}, | |||
| namespaceName: | |||
| namespaceName.kind === "success" ? namespaceName.result : null, | |||
| rescriptVersion: utils.findReScriptVersion(projectRootPath), | |||
| rescriptVersion: utils.findReScriptVersionForProjectRoot(projectRootPath), | |||
There was a problem hiding this comment.
This is the root of the problem really.
Here my project is called ronnies.be, which is mistaken for a file.
At this point, we know it is a folder, so we can shortcut things I think.
|
@nojaf ready for a new review...? |
|
@zth yup, go for it |
zth
approved these changes
Mar 28, 2025
|
Works like a charm in the prerelease channel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found out why the incremental build wasn't working yesterday.
Turns out I have a dot in my project folder name, this was mistaken for a file.
That file is not part of the project, thus the rescript version could not be found for the root.