add bitxor (^) unified operator #7216
Merged
+72
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MiryangJung great to see you in a PR, welcome! 😁 |
|
Hi @MiryangJung! Would be great to get this PR merged - do you have time to pick up work on it again? |
sure! I will redo the task. |
Merged
MiryangJung
force-pushed
the
unified-operator/lxor
branch
3 times, most recently
from
4d0f26a to
bd8ceb3
Compare
cometkim
reviewed
Mar 22, 2025
tests/syntax_tests/data/parsing/errors/typeDef/expected/nestedRecord.res.txt
Outdated
Show resolved
Hide resolved
MiryangJung
changed the title
MiryangJung
changed the title
cometkim
force-pushed
the
unified-operator/lxor
branch
from
bd8ceb3 to
695922c
Compare
Co-authored-by: Hyeseong Kim <[email protected]>
cometkim
force-pushed
the
unified-operator/lxor
branch
from
695922c to
6a5a015
Compare
cknitt
reviewed
Mar 23, 2025
Co-authored-by: Christoph Knittel <[email protected]>
|
Please also update the test output accordingly. |
oh! thx |
|
Oh, and could you also add a CHANGELOG entry, please? |
Ok! I've added it. But I'm not sure if I did it correctly 🤨 |
cknitt
reviewed
Mar 25, 2025
Thanks a lot! I adapted it a bit. |
cknitt
approved these changes
Mar 25, 2025
fhammerschmidt
pushed a commit
that referenced
this pull request
Apr 4, 2025
* add add lxor (^) unified operator * add bitxor Co-authored-by: Hyeseong Kim <[email protected]> * Update compiler/syntax/src/res_diagnostics.ml Co-authored-by: Christoph Knittel <[email protected]> * update the test output * CHANGELOG: Add unified bitwise (`^`) operator to the list of changes * Update CHANGELOG.md --------- Co-authored-by: Hyeseong Kim <[email protected]> Co-authored-by: Christoph Knittel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7172
When running make lib locally, the build is failing, and I’m currently checking it.