Skip to content

Fix installation link in README.md - #9138

Merged
cknitt merged 3 commits into
rescript-lang:masterfrom
flpezet:patch-1
Nov 1, 2026
Merged

cknitt merged 3 commits into
rescript-lang:masterfrom
flpezet:patch-1

Conversation

@flpezet

@flpezet flpezet commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Hi ! Title is self-explanatory. It's my first contribution in this project, feel free to change or reopen if needed.
Here the related issue: #9139
Best,
Florent

Checklist

  • Added a changelog fragment (see changes/README.md), or no release notes are needed and a maintainer should apply changelog:skip.
  • Gave every commit a description below its subject, saying why it is made (see "Commit messages" in CONTRIBUTING.md).
  • Signed off every commit for the DCO (git commit -s).

@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Changelog

📝 Documentation

Semantic Diff

3 commits · Full page

Fix installation link in README.md

40a97f5 · Florent Pezet · Oct 30, 2026, 18:42 UTC

Why

Each time we click the ReScript "installation" link on the README.md, it redirects to an old location leading to "404 page not found". We update with the correct link.

Correct changelog files for C.I

711445a · Florent Pezet · Oct 31, 2026, 12:21 UTC

Why

The C.I needs us to create a new file in "changes" directory rather than direct modifications to CHANGELOG.md

✨ Fix other broken links in the README.md.

db9e50c · Florent Pezet · Oct 31, 2026, 12:43 UTC · new

Why

In addition to installation links, some links "Introduction", "Upgrade" were also broken.

@cknitt
cknitt requested a review from fhammerschmidt October 30, 2026 12:51
@pkg-pr-new

pkg-pr-new Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript@9138

@rescript/belt

npm i https://pkg.pr.new/@rescript/belt@9138

@rescript/darwin-arm64

npm i https://pkg.pr.new/@rescript/darwin-arm64@9138

@rescript/linux-arm64

npm i https://pkg.pr.new/@rescript/linux-arm64@9138

@rescript/linux-x64

npm i https://pkg.pr.new/@rescript/linux-x64@9138

@rescript/runtime

npm i https://pkg.pr.new/@rescript/runtime@9138

@rescript/win32-x64

npm i https://pkg.pr.new/@rescript/win32-x64@9138

commit: db9e50c

@flpezet
flpezet force-pushed the patch-1 branch 3 times, most recently from 21646e3 to 138c265 Compare October 30, 2026 18:37
Why:
Each time we click the ReScript "installation" link on the README.md, it redirects to an old location leading to "404 page not found".
We update with the correct link.

Signed-off-by: Florent Pezet <florent.pezet@gembase.ai>

@fhammerschmidt fhammerschmidt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@fhammerschmidt
fhammerschmidt enabled auto-merge (squash) October 30, 2026 20:35
@codecov

codecov Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.74%. Comparing base (2303933) to head (db9e50c).
⚠️ Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9138      +/-   ##
==========================================
+ Coverage   81.72%   81.74%   +0.02%     
==========================================
  Files         460      460              
  Lines       64814    64944     +130     
==========================================
+ Hits        52970    53091     +121     
- Misses      11844    11853       +9     

see 43 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cknitt

cknitt commented Oct 31, 2026

Copy link
Copy Markdown
Member

CI error:

Add a changelog fragment instead of editing CHANGELOG.md. Release PRs use the changelog:release label.

Please follow/have your agent follow the new changelog process as described in https://github.com/rescript-lang/rescript/blob/master/changes/README.md

Why:
  The C.I needs us to create a new file in "changes" directory rather than direct modifications to CHANGELOG.md

Signed-off-by: Florent Pezet <florent.pezet@gembase.ai>
auto-merge was automatically disabled October 31, 2026 12:23

Head branch was pushed to by a user without write access

Why: In addition to installation links, some links "Introduction", "Upgrade" were also broken.

Signed-off-by: Florent Pezet <florent.pezet@gembase.ai>
@cknitt
cknitt merged commit 8e26a9c into rescript-lang:master Nov 1, 2026
26 checks passed
@cknitt

cknitt commented Nov 1, 2026

Copy link
Copy Markdown
Member

Thank you for your contribution!

@flpezet
flpezet deleted the patch-1 branch November 1, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants