Skip to content

Remove two stale CI and test steps - #9147

Merged
cknitt merged 2 commits into
masterfrom
ci-remove-stale-steps
Oct 31, 2026
Merged

cknitt merged 2 commits into
masterfrom
ci-remove-stale-steps

Conversation

@cknitt

@cknitt cknitt commented Oct 31, 2026

Copy link
Copy Markdown
Member

Two leftovers in CI and the test script no longer do anything useful.

  • The syntax benchmark step in ci.yml wrote its output to a file nothing read since benchmark tracking was disabled, followed by the commented-out benchmark-action steps. Both are gone, along with the benchmarks matrix flag only that step used, saving about 30 s on the linux-arm64 job. The syntax_benchmarks executable and make bench stay.
  • scripts/test.js skipped the docstring tests on macOS 13 to work around hangs on that runner. CI runs on macos-26 and the Makefile refuses Intel Macs, so the docstring tests now always run.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Kbf3gKyiYMf54wPRxFdUWe

cknitt and others added 2 commits October 31, 2026 06:05
The step wrote its output to a file nothing read since benchmark tracking
was disabled, so it only cost about 30 seconds per run.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Kbf3gKyiYMf54wPRxFdUWe
Signed-off-by: Christoph Knittel <ck@cca.io>
The skip for macOS 13 worked around hangs on a runner CI no longer uses:
CI runs on macos-26 and the Makefile refuses Intel Macs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Kbf3gKyiYMf54wPRxFdUWe
Signed-off-by: Christoph Knittel <ck@cca.io>
@github-actions

Copy link
Copy Markdown

Changelog

🏠 Internal

  • Remove the unused syntax benchmark CI step and the macOS 13 docstring test workaround.

Semantic Diff

2 commits · Full page

Drop the syntax benchmark step from CI

9f05294 · cknitt + Claude · Oct 31, 2026, 06:05 UTC

The step wrote its output to a file nothing read since benchmark tracking was disabled, so it only cost about 30 seconds per run.

Always run the docstring tests on macOS

6e40255 · cknitt + Claude · Oct 31, 2026, 06:05 UTC

The skip for macOS 13 worked around hangs on a runner CI no longer uses: CI runs on macos-26 and the Makefile refuses Intel Macs.

@pkg-pr-new

pkg-pr-new Bot commented Oct 31, 2026

Copy link
Copy Markdown

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript@9147

@rescript/belt

npm i https://pkg.pr.new/@rescript/belt@9147

@rescript/darwin-arm64

npm i https://pkg.pr.new/@rescript/darwin-arm64@9147

@rescript/linux-arm64

npm i https://pkg.pr.new/@rescript/linux-arm64@9147

@rescript/linux-x64

npm i https://pkg.pr.new/@rescript/linux-x64@9147

@rescript/runtime

npm i https://pkg.pr.new/@rescript/runtime@9147

@rescript/win32-x64

npm i https://pkg.pr.new/@rescript/win32-x64@9147

commit: 6e40255

@github-actions

Copy link
Copy Markdown

@cknitt

cknitt commented Oct 31, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-31T07:34:30.843059Z 6e40255 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 6e40255016

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@cknitt
cknitt marked this pull request as ready for review October 31, 2026 10:07
@cknitt
cknitt requested a review from cristianoc October 31, 2026 10:07
@cknitt
cknitt merged commit 7928f37 into master Oct 31, 2026
26 checks passed
@cknitt
cknitt deleted the ci-remove-stale-steps branch October 31, 2026 12:10
aspeddro pushed a commit to aspeddro/rescript-compiler that referenced this pull request Oct 31, 2026
Signed-off-by: Pedro Castro <aspeddro@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants