Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typos in Comments #123

Merged
merged 1 commit into from
Jun 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/build/clean.rs
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ fn remove_compile_asset(package: &packages::Package, source_file: &str, extensio

pub fn remove_compile_assets(package: &packages::Package, source_file: &str) {
// optimization
// only issue cmti if htere is an interfacce file
// only issue cmti if there is an interfacce file
for extension in &["cmj", "cmi", "cmt", "cmti"] {
remove_compile_asset(package, source_file, extension);
}
Expand Down
4 changes: 2 additions & 2 deletions src/build/compile.rs
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,10 @@ pub fn compile(
// for sure clean modules -- after checking the hash of the cmi
let mut clean_modules = AHashSet::<String>::new();

// TODO: calculate the real dirty modules from the orginal dirty modules in each iteration
// TODO: calculate the real dirty modules from the original dirty modules in each iteration
// taken into account the modules that we know are clean, so they don't propagate through the
// deps graph
// create a hashset of all clean modules form the file-hashes
// create a hashset of all clean modules from the file-hashes
let mut loop_count = 0;
let mut files_total_count = compiled_modules.len();
let mut files_current_loop_count;
Expand Down
6 changes: 3 additions & 3 deletions src/build/packages.rs
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ pub fn read_folders(
/// Given a projects' root folder and a `bsconfig::Source`, this recursively creates all the
/// sources in a flat list. In the process, it removes the children, as they are being resolved
/// because of the recursiveness. So you get a flat list of files back, retaining the type_ and
/// wether it needs to recurse into all structures
/// whether it needs to recurse into all structures
fn get_source_dirs(source: bsconfig::Source, sub_path: Option<PathBuf>) -> AHashSet<bsconfig::PackageSource> {
let mut source_folders: AHashSet<bsconfig::PackageSource> = AHashSet::new();

Expand Down Expand Up @@ -276,7 +276,7 @@ pub fn read_dependency(

/// # Make Package

/// Given a bsconfig, reqursively finds all dependencies.
/// Given a bsconfig, recursively finds all dependencies.
/// 1. It starts with registering dependencies and
/// prevents the operation for the ones which are already
/// registerd for the parent packages. Especially relevant for peerDependencies.
Expand Down Expand Up @@ -430,7 +430,7 @@ fn read_packages(project_root: &str, workspace_root: Option<String>) -> AHashMap
/// data from the config and pushes it forwards. Another thing is the 'type_', some files / folders
/// can be marked with the type 'dev'. Which means that they may not be around in the distributed
/// NPM package. The file reader allows for this, just warns when this happens.
/// TODO -> Check wether we actually need the `fs::Metadata`
/// TODO -> Check whether we actually need the `fs::Metadata`
pub fn get_source_files(
package_dir: &Path,
filter: &Option<regex::Regex>,
Expand Down
Loading