Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(render): Prettier breaking if mso comments #1839

Open
wants to merge 7 commits into
base: canary
Choose a base branch
from

Conversation

gabrielmfern
Copy link
Collaborator

This is meant for #1813.

The issue is that comments, like the one below, would become formatted in such a way that would make Outlook
not properly detect the conditional comment, and thus not render in Outlook.

<!--[if mso]><i style="mso-font-width:366.66666666666663%;mso-text-raise:24" hidden>&#8202;&#8202;&#8202;</i><![endif]-->
<!--[if mso
 ]><i
   style="mso-font-width:366.66666666666663%;mso-text-raise:24"
   hidden
   >&#8202;&#8202;&#8202;</i
 ><!
[endif]-->

To fix this issue, this PR proposes that we firstly modify the html prettier plugin in such a way that it always ignores if mso comments like these. This isn't very hard at all, since the parser for the plugin already has a node type for ieConditionalComments.

Copy link

changeset-bot bot commented Dec 24, 2024

🦋 Changeset detected

Latest commit: ea26718

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@react-email/render Patch
@react-email/components Patch
react-email-with-aws-ses Patch
react-email-with-mailersend Patch
react-email-with-nodemailer Patch
react-email-with-plunk Patch
react-email-with-postmark Patch
react-email-with-resend Patch
react-email-with-sendgrid Patch
react-email-with-next-scaleway Patch
react-email-with-node-scaleway Patch
react-email-starter Patch
create-email Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-email ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2024 6:55pm
react-email-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2024 6:55pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant