- 
                Notifications
    You must be signed in to change notification settings 
- Fork 9
feat: Inbound API #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Inbound API #134
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 6 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="spec/emails/receiving_spec.rb">
<violation number="1" location="spec/emails/receiving_spec.rb:9">
Rule violated: **No `should` in tests**
Replace the `it` descriptions that use “should” with direct, declarative phrasing to comply with the project’s “No `should` in tests” guideline.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
| end | ||
|  | ||
| describe "get" do | ||
| it "should retrieve a received email" do | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rule violated: No should in tests
Replace the it descriptions that use “should” with direct, declarative phrasing to comply with the project’s “No should in tests” guideline.
Prompt for AI agents
Address the following comment on spec/emails/receiving_spec.rb at line 9:
<comment>Replace the `it` descriptions that use “should” with direct, declarative phrasing to comply with the project’s “No `should` in tests” guideline.</comment>
<file context>
@@ -0,0 +1,181 @@
+  end
+
+  describe "get" do
+    it "should retrieve a received email" do
+      resp = {
+        "object" => "email",
</file context>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Just minor nits to cleanup some comments here too. Nbd, all routes look correct.
Co-authored-by: Lucas da Costa <[email protected]>
Co-authored-by: Lucas da Costa <[email protected]>
Co-authored-by: Lucas da Costa <[email protected]>
Summary by cubic
Add inbound email and attachment receiving support to the Ruby SDK so developers can list and fetch received emails and their attachments. Includes pagination and attachment download URLs, plus examples and tests.