Skip to content

Conversation

@drish
Copy link
Collaborator

@drish drish commented Oct 20, 2025

Summary by cubic

Add inbound email and attachment receiving support to the Ruby SDK so developers can list and fetch received emails and their attachments. Includes pagination and attachment download URLs, plus examples and tests.

  • New Features
    • Added Resend::Emails::Receiving.get and .list (limit, after, before).
    • Added Resend::Attachments::Receiving.get and .list (requires email_id; supports pagination; returns download_url and expires_at).
    • Required new modules in lib/resend.rb.
    • Added examples/receiving_emails.rb and comprehensive RSpec tests.

@drish drish requested a review from isabellaaquino October 20, 2025 22:10
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 6 files

Prompt for AI agents (all 1 issues)

Understand the root cause of the following 1 issues and fix them.


<file name="spec/emails/receiving_spec.rb">

<violation number="1" location="spec/emails/receiving_spec.rb:9">
Rule violated: **No `should` in tests**

Replace the `it` descriptions that use “should” with direct, declarative phrasing to comply with the project’s “No `should` in tests” guideline.</violation>
</file>

React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.

end

describe "get" do
it "should retrieve a received email" do
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule violated: No should in tests

Replace the it descriptions that use “should” with direct, declarative phrasing to comply with the project’s “No should in tests” guideline.

Prompt for AI agents
Address the following comment on spec/emails/receiving_spec.rb at line 9:

<comment>Replace the `it` descriptions that use “should” with direct, declarative phrasing to comply with the project’s “No `should` in tests” guideline.</comment>

<file context>
@@ -0,0 +1,181 @@
+  end
+
+  describe &quot;get&quot; do
+    it &quot;should retrieve a received email&quot; do
+      resp = {
+        &quot;object&quot; =&gt; &quot;email&quot;,
</file context>
Fix with Cubic

@drish drish changed the title feat: Inbound attachment methods feat: Inbound API Oct 21, 2025
Copy link
Contributor

@lucasfcosta lucasfcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Just minor nits to cleanup some comments here too. Nbd, all routes look correct.

@drish drish merged commit 3f7027c into main Oct 27, 2025
9 checks passed
@drish drish deleted the feat/inbound branch October 27, 2025 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants