Skip to content

Conversation

@jorisdejong
Copy link
Contributor

The orginal function checks if the value is in range, but then still set the actual option using the out of range value

@MennoVink
Copy link
Collaborator

@flyingrub another quickstart param thing for you :)
I wonder if it should go to zero though, shouldn't it clamp rather than just choose 0? ie clamp the value to be between [0..options.size())

@jorisdejong
Copy link
Contributor Author

@flyingrub The set to zero is unchanged from your original code. I'd prefer clamping to options.size() too, but I assumed it was resetting to 0 for a reason :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants