Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(db-migrations): add basic support for db migrations #340

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

guergabo
Copy link
Contributor

@guergabo guergabo commented May 28, 2024

x

@guergabo guergabo self-assigned this May 28, 2024
@guergabo guergabo added the enhancement New feature or request label May 28, 2024
@guergabo guergabo changed the title feat(db-migrations): first commit feat(db-migrations): add basic support for db migrations May 28, 2024
Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 30.92105% with 105 lines in your changes are missing coverage. Please review.

Project coverage is 57.72%. Comparing base (32c8746) to head (f48faf8).
Report is 3 commits behind head on main.

Files Patch % Lines
...ernal/app/subsystems/aio/store/postgres/version.go 0.00% 54 Missing ⚠️
...nternal/app/subsystems/aio/store/sqlite/version.go 38.09% 19 Missing and 7 partials ⚠️
.../app/subsystems/aio/store/migrations/migrations.go 57.69% 15 Missing and 7 partials ⚠️
...rnal/app/subsystems/aio/store/postgres/postgres.go 0.00% 2 Missing ⚠️
internal/app/subsystems/aio/store/sqlite/sqlite.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #340      +/-   ##
==========================================
+ Coverage   55.98%   57.72%   +1.74%     
==========================================
  Files         113      116       +3     
  Lines        9910    10091     +181     
==========================================
+ Hits         5548     5825     +277     
+ Misses       3996     3884     -112     
- Partials      366      382      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guergabo guergabo requested a review from dfarr May 28, 2024 14:09
@guergabo guergabo marked this pull request as ready for review May 31, 2024 15:55
@guergabo guergabo requested a review from dfarr June 2, 2024 03:00
@guergabo
Copy link
Contributor Author

guergabo commented Jun 2, 2024

Ready for review. Before merging have to remove both migrations file, but keeping for review as example of what they would look like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants