Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpret "Authorization: Basic <user>:<pass>" header as basic auth #115

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

srihari93
Copy link
Contributor

Trying to add the ability to interpret a special header line Authorization: Basic <user>:<pass> as basic authorization.
This follows the VS code rest plugin's style of interpreting basic auth.


POST https://fake.com/api/some
Authorization: Basic user:password
Content-Type: application/json

{
  "key": "jafa"
}

is converted to curl -sSL --compressed -X 'POST' -H 'Content-Type: application/json' -d 'key=jafa' -u 'user:password' 'https://fake.com/api/some'


@NTBBloodbath
There is an alternative suggestion here on how to do the basic auth, both of these styles can live together, IMHO. I went for this style as its compatible with the heavily used VS code. Feel free to reject this if the VS code style is not palatable. Also fine if you have issues with style, let me know I will fix and get back to you.

@LucasRitossa
Copy link

When will this be merged?

@NTBBloodbath
Copy link
Member

When will this be merged?

Please refer to latest #126 notice.

I know this is something important, however, current codebase is fragile on its current state so merging any existing PR would lead to merge conflicts with any other PR and it's not worth it right now. Plugin rewrite is on its way tho, stay tuned and my apologies for the delay!

@kronolynx
Copy link

Is this going to be added to version 2 ?

@NTBBloodbath
Copy link
Member

NTBBloodbath commented May 16, 2024

Is this going to be added to version 2 ?

Yessir, however there is no ETA. I have to fix a couple of bugs and a few other things first. Also, this implementation currently doesn't work for us due to changes in v2 so I have to redo it from scratch :)

@kronolynx
Copy link

kronolynx commented Sep 27, 2024

Hi, is this functionality going to be added to version 3? it is part of Intellij's http client spec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants