Deprecate ClusterState types
#2434
Draft
+237
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 17, 2024
muhamadazmy
force-pushed
the
pr2434
branch
2 times, most recently
from
de80d30 to
d896c99
Compare
muhamadazmy
force-pushed
the
pr2434
branch
3 times, most recently
from
729d7dd to
16764bb
Compare
muhamadazmy
changed the title
muhamadazmy
force-pushed
the
pr2434
branch
4 times, most recently
from
f8d3c6c to
1e57e8a
Compare
muhamadazmy
changed the title
ClusterState types
Summary: derprecate old cluster state that included information about partition state. A new ClusterState object is introduced that only have livenss information
Comment on lines
+13
to
+19
| import "restate/common.proto"; | ||
| import "restate/cluster.proto"; | ||
| import "google/protobuf/empty.proto"; | ||
| import "google/protobuf/duration.proto"; | ||
| import "google/protobuf/timestamp.proto"; | ||
|
|
||
| package restate.deprecated_cluster; |
There was a problem hiding this comment.
I'm assuming that this file is a simple rename that github doesn't recognize as a rename, right?
There was a problem hiding this comment.
It's confused because we still have a file with the same old name (cluster.proto)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate
ClusterStatetypesSummary:
derprecate old cluster state that included information about
partition state.
A new ClusterState object is introduced that only have livenss information
Stack created with Sapling. Best reviewed with ReviewStack.
ClusterStatetypes #2434