[Bifrost] Let providers propose their own parameters #2451
+888
−123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 20, 2024
Test Results 7 files ±0 7 suites ±0 5m 17s ⏱️ +38s For more details on these errors, see this check. Results for commit f4d6cad. ± Comparison against base commit 1ac1f70. ♻️ This comment has been updated with latest results. |
- BifrostAdmin can now init empty logs configuration - BifrostAdmin can now auto extend the chain - Providers now have control over suggesting a new segment configuration - Introduces a temporary copy of NodeSetSelector into bifrost until log-controller is removed
AhmedSoliman
commented
Dec 23, 2024
Comment on lines
+938
to
+941
| BifrostAdmin::new(&bifrost, &metadata_writer, &metadata_store_client) | ||
| .init_metadata() | ||
| .await | ||
| .map_err(|e| LogsControllerError::Other(e.into()))?; |
There was a problem hiding this comment.
Note: this conflicts with the changes that @tillrohrmann is working on in #2452
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack created with Sapling. Best reviewed with ReviewStack.