[datafusion] add a new table for introspecting the cluster's config by MohamedBassem · Pull Request #4964 · restatedev/restate

MohamedBassem · 2026-06-23T08:06:33Z

This PR introduces a datafusion based table for introspecting configs across nodes (available over restatectl). This is meant to be a more ergonomic way for debugging config values than the USR1 signal mechanism that we have today. The implementation heavily mimics other tables in error handling, code structure, etc.

Note: Our configs can sometimes include secret tokens (e.g. S3 access tokens, etc). This PR has a best effort redaction for such secrets, however, it doesn't guarantee that it'll cover every secret. The premise here is that this table is privileged (you need access to the fabric port to query it), so it's ok to do so. If we want better guarantees, we can introduce a new Redacted<T> which always serde serializes to Redacted and use it for all of the secrets in our configs.

Example usage:

❯❯❯ cargo run -p restatectl sql "select * from configs where key LIKE '%num_retained%'"                                                  feat/df-configs
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.27s
     Running `target/debug/restatectl sql 'select * from configs where key LIKE '\''%num_retained%'\'''`
 PLAIN_NODE_ID  GEN_NODE_ID  KEY                            VALUE
 N1             N1:18        worker.snapshots.num-retained  1
 N3             N3:16        worker.snapshots.num-retained  1
 N2             N2:19        worker.snapshots.num-retained  1

3 rows. Query took 54.299783ms

MohamedBassem · 2026-06-23T08:07:14Z

This is still not ready for review. Sent it out by mistake.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 53bce7f974

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 013f94473c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 74516f8969

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9b5a3469bc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

AhmedSoliman

Very cool. Excited to get this merged. Left a few comments but overall it looks good. The most notable is to add some facility to disable this table via config.

AhmedSoliman · 2026-06-24T17:49:08Z

 mod network_server;
 mod roles;

+use std::sync::Arc;


AhmedSoliman · 2026-06-24T17:54:43Z

+        let schema = projection.clone();
+        let mut stream_builder = RecordBatchReceiverStream::builder(projection, 2);
+        let tx = stream_builder.tx();
+        let node_id = self.metadata.my_node_id();


Is there risk of this scanner running before the node acquiring its own node_id? If so, can we use the fallible version my_node_id_opt to avoid crashing?

If other tables already have the same risk, then it's okay to leave as is.

yeah, both loglet workers and bifrost read streams seam to be reading the node_id in the beginning of the scan function as well.

AhmedSoliman · 2026-06-24T18:03:46Z

+            self.remote_scanner_manager.clone(),
+            None, // local scanner is registered separately by the node
+        )?;
+        crate::configs::register_self(


I can imagine scenarios where we might want to disable access to this table. Can we let this be controlled by a config option? (enabled by default though).

Where do you think would be a good section to place this knob? admin.query_engine?

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d61fa21823

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-06-25T06:07:33Z

+/// against the hyphenated forms here.
+fn is_potentially_secret(key: &str) -> bool {
+    let key = key.to_ascii_lowercase();
+    [


Redact private-key config entries

Fresh evidence beyond the earlier redaction comments is that Kafka additional_options can carry arbitrary librdkafka keys (crates/types/src/config/kafka.rs:30-35), and librdkafka defines ssl.key.pem and sasl.oauthbearer.assertion.private.key.pem as client private-key strings (Confluent docs). Flattened keys such as ingress.kafka-clusters[0].ssl.key.pem contain none of the current needles, so the config table returns the PEM material unredacted; please include private-key/key-pem style names or redact these option maps more conservatively.

Useful? React with 👍 / 👎.

[datafusion] add a new table for introspecting the cluster's config

53bce7f

MohamedBassem marked this pull request as draft June 23, 2026 08:06

chatgpt-codex-connector Bot reviewed Jun 23, 2026

View reviewed changes

Comment thread crates/storage-query-datafusion/src/configs/table.rs Outdated

secret readaction

013f944

MohamedBassem requested a review from AhmedSoliman June 23, 2026 09:52

MohamedBassem marked this pull request as ready for review June 23, 2026 09:52

chatgpt-codex-connector Bot reviewed Jun 23, 2026

View reviewed changes

Comment thread crates/storage-query-datafusion/src/configs/table.rs Outdated

local claude review comments

74516f8

chatgpt-codex-connector Bot reviewed Jun 23, 2026

View reviewed changes

Comment thread crates/storage-query-datafusion/src/configs/table.rs Outdated

MohamedBassem added 2 commits June 24, 2026 17:21

better handling for array of objects + flatting tests

01d8319

include authorization in secret matching

9b5a346

chatgpt-codex-connector Bot reviewed Jun 24, 2026

View reviewed changes

Comment thread crates/storage-query-datafusion/src/configs/table.rs Outdated

fix clippy

86f60d9

AhmedSoliman reviewed Jun 24, 2026

View reviewed changes

review comments

d61fa21

chatgpt-codex-connector Bot reviewed Jun 25, 2026

View reviewed changes

Uh oh!

Conversation

MohamedBassem commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MohamedBassem commented Jun 23, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

AhmedSoliman left a comment

Choose a reason for hiding this comment

Uh oh!

AhmedSoliman Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

AhmedSoliman Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

MohamedBassem Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

AhmedSoliman Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

MohamedBassem Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

MohamedBassem commented Jun 23, 2026 •

edited

Loading