Skip to content

Introduce sys_vqueue_entry_status for detailed per-entry status#4966

Merged
AhmedSoliman merged 1 commit into
mainfrom
pr4966
Jun 24, 2026
Merged

Introduce sys_vqueue_entry_status for detailed per-entry status#4966
AhmedSoliman merged 1 commit into
mainfrom
pr4966

Conversation

@AhmedSoliman

@AhmedSoliman AhmedSoliman commented Jun 23, 2026

Copy link
Copy Markdown
Member

Add a DataFusion system table backed by the vqueue entry status table so operators can inspect EntryStatusHeader fields directly. The table exposes entry and vqueue identifiers, stage/status, scheduling key fields, entry statistics, metadata, retry information, and latest/total WaitStats durations.

Add storage API and partition-store scan support for entry status headers, register the table in the query context and table docs, and cover the mapping with a focused DataFusion test. Include an unreleased note for the new user-facing SQL table.


Stack created with Sapling. Best reviewed with ReviewStack.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ddb69dbdb4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/storage-query-datafusion/src/vqueue_entry_status/tests.rs Outdated
@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown

Test Results

  8 files  ±0    8 suites  ±0   4m 58s ⏱️ -14s
 61 tests ±0   61 ✅ ±0  0 💤 ±0  0 ❌ ±0 
268 runs  ±0  268 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8fe0a4c. ± Comparison against base commit 9447224.

♻️ This comment has been updated with latest results.

@MohamedBassem MohamedBassem left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool. Tons of stats per entry!

@nikrooz nikrooz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AhmedSoliman , tested it and looks great.
Since this should become the source of truth for invocation status, it's tempting to suggest we add service (or target), scope and limit key in there as well. But I understand if they don't belong to this table.

Add a DataFusion system table backed by the vqueue entry status table so operators can inspect EntryStatusHeader fields directly. The table exposes entry and vqueue identifiers, stage/status, scheduling key fields, entry statistics, metadata, retry information, and latest/total WaitStats durations.

Add storage API and partition-store scan support for entry status headers, register the table in the query context and table docs, and cover the mapping with a focused DataFusion test. Include an unreleased note for the new user-facing SQL table.
@AhmedSoliman AhmedSoliman merged commit 8546446 into main Jun 24, 2026
12 checks passed
@AhmedSoliman AhmedSoliman deleted the pr4966 branch June 24, 2026 17:05
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants