Skip to content

Commit

Permalink
Remove cause from TerminalError, as it's not supported by the protocol (
Browse files Browse the repository at this point in the history
  • Loading branch information
slinkydeveloper authored Jan 10, 2024
1 parent 50f1e5e commit 68f58bf
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
1 change: 0 additions & 1 deletion src/restate_context_impl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,6 @@ async function executeWithRetries<T>(
`Retries exhausted for ${name}. Last error: ${error.name}: ${error.message}`,
{
errorCode: ErrorCodes.INTERNAL,
cause: error,
}
);
}
Expand Down
2 changes: 1 addition & 1 deletion src/types/errors.ts
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ export class RestateError extends Error {
// Does not lead to Restate retries
// Leads to an output message with a failure defined
export class TerminalError extends RestateError {
constructor(message: string, options?: { errorCode?: number; cause?: any }) {
constructor(message: string, options?: { errorCode?: number }) {
super(message, options);
}
}
Expand Down
6 changes: 5 additions & 1 deletion src/utils/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,11 @@ export function jsonDeserialize<T>(json: string): T {
// When using google.protobuf.Value in RPC handler responses, we want to roughly match the behaviour of JSON.stringify
// for example in converting Date objects to a UTC string
export function jsonSafeAny(key: string, value: any): any {
if (value !== undefined && value !== null && typeof value.toJSON == "function") {
if (
value !== undefined &&
value !== null &&
typeof value.toJSON == "function"
) {
return value.toJSON(key) as any;
} else if (globalThis.Array.isArray(value)) {
// in place replace
Expand Down

0 comments on commit 68f58bf

Please sign in to comment.