Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server API ergonomics #220

Closed
slinkydeveloper opened this issue Dec 22, 2023 · 0 comments · Fixed by #221
Closed

Server API ergonomics #220

slinkydeveloper opened this issue Dec 22, 2023 · 0 comments · Fixed by #221
Assignees
@slinkydeveloper
Labels
devex

Comments

@slinkydeveloper
Copy link
Contributor

slinkydeveloper commented Dec 22, 2023 •
edited
Loading

While working on restatedev/node-template-generator#18 I stumbled on several issues:

  • It's unclear how to start the server on port 0.
  • I can't get notified on when the server starts listening, and then continue the execution
  • I can't stop the server
  • I can't add server options myself Allow to pass http2.ServerOptions #219

Perhaps we should align the server object in a similar fashion to express https://expressjs.com/it/4x/api.html#app.listen, where basically server just implements a request handler and a user can use the regular node APIs to start/stop server, define options etc.

We can do that while still providing the "helper" method listen as we have it now.
@slinkydeveloper slinkydeveloper mentioned this issue Dec 22, 2023
Closed
@slinkydeveloper slinkydeveloper changed the title How to start on port 0? Server API ergonomics Dec 22, 2023
@slinkydeveloper slinkydeveloper mentioned this issue Dec 22, 2023
Closed
@slinkydeveloper slinkydeveloper self-assigned this Jan 9, 2024
slinkydeveloper added a commit to restatedev/node-template-generator that referenced this issue Jan 9, 2024
@slinkydeveloper
Adapt example to use the changes from restatedev/sdk-typescript#220
a356140
@slinkydeveloper slinkydeveloper mentioned this issue Jan 9, 2024
Merged
slinkydeveloper added a commit to restatedev/node-template-generator that referenced this issue Jan 9, 2024
@slinkydeveloper
Adapt example to use the changes from restatedev/sdk-typescript#220
e79f9c5
@slinkydeveloper slinkydeveloper mentioned this issue Jan 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slinkydeveloper slinkydeveloper

Labels
devex
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Server API ergonomics slinkydeveloper/sdk-typescript
1 participant
@slinkydeveloper