Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to pass http2.ServerOptions #219

Closed
wants to merge 1 commit into from
Closed

Allow to pass http2.ServerOptions #219

wants to merge 1 commit into from

Conversation

slinkydeveloper
Copy link
Contributor

Fix #201

@slinkydeveloper slinkydeveloper mentioned this pull request Dec 22, 2023
Closed
igalshilman
igalshilman approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@igalshilman igalshilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slinkydeveloper
Copy link
Contributor Author

let's hold this, perhaps we can solve this issue with #220 instead, without changing the listen() signature

@igalshilman
Copy link
Contributor

I think that this is good change on its own, this doesn't really change the listen signature (as in .listen())
and allow folks to configure the server as they want.

@slinkydeveloper
Copy link
Contributor Author

Superseded by #221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igalshilman igalshilman igalshilman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to set server options for HTTP endpoint
2 participants
@slinkydeveloper @igalshilman