Add failure variant for GetState, PollInputStream and SleepEntryMessage #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to merge #195 first |
slinkydeveloper
approved these changes
Dec 18, 2023
tillrohrmann
force-pushed
the
issues/210
branch
from
745971e to
b5e9da3
Compare
igalshilman
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
@tillrohrmann thanks for changes, they look good to me +1 to merge when the tests pass.
I've tried to re-trigger the test, didn't help.
perhaps you need to rebase on the main branch again?
|
Thanks for the review @igalshilman. I think the e2e tests are currently failing because the runtime image is missing some changes. Locally the e2e tests including restatedev/e2e#228 are passing. |
This commit updates the SDK to the latest service protocol version. Part of it is to enable failure variants for the GetState, PollInputStream and SleepEntryMessages so that the runtime can cancel these entries. This commit also adds tests for verifying the changes. This fixes restatedev#210.
tillrohrmann
force-pushed
the
issues/210
branch
from
b5e9da3 to
1785bd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the SDK to the latest service protocol version. Part of it is to enable failure variants for the GetState, PollInputStream and SleepEntryMessages so that the runtime can cancel these entries. This commit also adds tests for verifying the changes.
This fixes #210.