Introduce EndMessage #216
Merged
Introduce EndMessage #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for creating this PR @slinkydeveloper. As far as I can tell, the changes look good to me. I had a question about why it is ok to not await certain calls in the resultBytes callback.
| @@ -303,7 +308,7 @@ export class StateMachine<I, O> implements RestateStreamConsumer { | |||
| "Function completed with an error: " + error.message | |||
| ); | |||
|
|
|||
| this.finishWithError(error); | |||
| this.sendErrorAndFinish(error); | |||
There was a problem hiding this comment.
Is a bit unrelated to the changes of this PR: Why is it ok to not await the result of this async function? Same question applies to the this.finish(value) call above.
There was a problem hiding this comment.
I'm not sure why, but just reading the code down the stack this function is async only for waiting the connection.end(), and probably it doesn't matter to wait on that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of restatedev/service-protocol#49