Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cause from TerminalError, as it's not supported by the protocol #224

Merged
merged 1 commit into from
Jan 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/restate_context_impl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,6 @@ async function executeWithRetries<T>(
`Retries exhausted for ${name}. Last error: ${error.name}: ${error.message}`,
{
errorCode: ErrorCodes.INTERNAL,
cause: error,
}
);
}
Expand Down
2 changes: 1 addition & 1 deletion src/types/errors.ts
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ export class RestateError extends Error {
// Does not lead to Restate retries
// Leads to an output message with a failure defined
export class TerminalError extends RestateError {
constructor(message: string, options?: { errorCode?: number; cause?: any }) {
constructor(message: string, options?: { errorCode?: number }) {
super(message, options);
}
}
Expand Down
6 changes: 5 additions & 1 deletion src/utils/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,11 @@ export function jsonDeserialize<T>(json: string): T {
// When using google.protobuf.Value in RPC handler responses, we want to roughly match the behaviour of JSON.stringify
// for example in converting Date objects to a UTC string
export function jsonSafeAny(key: string, value: any): any {
if (value !== undefined && value !== null && typeof value.toJSON == "function") {
if (
value !== undefined &&
value !== null &&
typeof value.toJSON == "function"
) {
return value.toJSON(key) as any;
} else if (globalThis.Array.isArray(value)) {
// in place replace
Expand Down
Loading