fix(logger): make logger optional, don't use dummy logger

src/database/provider/arango/graph.ts

@@ -21,9 +21,9 @@ import { Logger } from 'winston';
 export class ArangoGraph extends Arango implements GraphDatabaseProvider {
   constructor(
     db: Database,
-    public readonly logger: Logger,
     public readonly graph: Graph,
     public readonly edgeDefConfig: any,
+    public readonly logger?: Logger,
   ) {
     super(db);
   }

src/database/provider/arango/index.ts

@@ -85,13 +85,6 @@ const connect = async (conf: any, logger: Logger): Promise<any> => {
  * @return {Arango}        ArangoDB provider
  */
 export const create = async (conf: any, logger: any, graphName?: string, edgeDefConfig?: any): Promise<Arango> => {
-  if (!logger) {
-    logger = {
-      verbose: () => { },
-      info: () => { },
-      error: () => { },
-    };
-  }
   let graph;
   const conn = await connect(conf, logger);
   let db: Arango;

test/graphs.spec.ts

@@ -1,3 +1,4 @@
+import {} from 'mocha';
 import * as should from 'should';
 import * as _ from 'lodash';
 import { createLogger } from '@restorecommerce/logger';
@@ -24,16 +25,8 @@ const providers = [
   }
 ];
 
-const arrUnique = (arr) => {
-  let cleaned = [];
-  arr.forEach((itm) => {
-    let unique = true;
-    cleaned.forEach((itm2) => {
-      if (_.isEqual(itm, itm2)) unique = false;
-    });
-    if (unique) cleaned.push(itm);
-  });
-  return cleaned;
+const arrUnique = <T>(arr: T[]) => {
+  return [...new Set<T>(arr)];
 };
 
 const testProvider = (providerCfg) => {