fix(stubs): fix stub names

restorecommerce · May 7, 2024 · dbf4826 · dbf4826
1 parent aaa6b76
commit dbf4826
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 12 deletions.
diff --git a/src/stub.ts b/src/stub.ts
@@ -13,7 +13,13 @@ export abstract class Stub
   static cfg: any = null;
   static logger: Logger = null;
 
-  abstract get type(): string;
+  private static getType<T extends Stub>(stub: T): string {
+    return stub.constructor.name;
+  }
+
+  get type(): string {
+    return Stub.getType(this);
+  }
 
   constructor(
     public courier: Courier,

diff --git a/src/stubs/dhl_soap.ts b/src/stubs/dhl_soap.ts
@@ -311,10 +311,6 @@ class DHLSoap extends Stub {
     },
   };
 
-  get type(): string {
-    return this.constructor.name; // 'DHLSoap';
-  }
-
   get clients(): ClientMap {
     return DHLSoap._clients;
   }
@@ -702,4 +698,4 @@ class DHLSoap extends Stub {
   }
 };
 
-Stub.register('DHLSoap', DHLSoap);
+Stub.register(DHLSoap.constructor.name, DHLSoap);
diff --git a/src/stubs/dummy.ts b/src/stubs/dummy.ts
@@ -1,11 +1,7 @@
 import { FlatAggregatedFulfillment } from '../utils.js';
 import { Stub } from '../stub.js';
 
-class DummyStub extends Stub {
-
-  get type(): string {
-    return this.constructor.name;
-  }
+class Dummy extends Stub {
 
   override async getTariffCode(
     fulfillment: FlatAggregatedFulfillment
@@ -38,4 +34,4 @@ class DummyStub extends Stub {
   }
 }
 
-Stub.register('Dummy', DummyStub);
+Stub.register(Dummy.constructor.name, Dummy);