refactor(test): add test for GQL pre and post processor

restorecommerce · Aug 29, 2024 · dd43f11 · dd43f11
1 parent f7ddb3a
commit dd43f11
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 9 deletions.
diff --git a/packages/facade/src/gql/protos/graphql.ts b/packages/facade/src/gql/protos/graphql.ts
@@ -21,7 +21,7 @@ export const preProcessGQLInput = async (
   data: any,
   model: GraphQLInputObjectType | GraphQLEnumType | GraphQLInputField | GraphQLInputType
 ): Promise<any> => {
-  if (data === undefined) {
+  if (data === null || data === undefined) {
     return undefined;
   }
 
@@ -96,8 +96,8 @@ export const preProcessGQLInput = async (
   return data;
 };
 
-export const postProcessGQLValue = (data: any, model: GraphQLOutputType): any => {
-  if (data === undefined) {
+export const postProcessGQLOutput = (data: any, model: GraphQLOutputType): any => {
+  if (data === null || data === undefined) {
     return undefined;
   }
 
@@ -120,7 +120,7 @@ export const postProcessGQLValue = (data: any, model: GraphQLOutputType): any =>
       const converted = Object.keys(fields).filter(
         key => key in data
       ).map(
-        key => postProcessGQLValue(data[key], fields[key].type)
+        key => postProcessGQLOutput(data[key], fields[key].type)
       );
       return {
         ...data,
@@ -130,12 +130,12 @@ export const postProcessGQLValue = (data: any, model: GraphQLOutputType): any =>
   }
 
   if (model instanceof GraphQLNonNull) {
-    return postProcessGQLValue(data, model.ofType);
+    return postProcessGQLOutput(data, model.ofType);
   }
 
   if (model instanceof GraphQLList) {
     return data.map(
-      (d: any) => postProcessGQLValue(d, model.ofType)
+      (d: any) => postProcessGQLOutput(d, model.ofType)
     );
   }
 

diff --git a/packages/facade/src/gql/protos/resolvers.ts b/packages/facade/src/gql/protos/resolvers.ts
@@ -8,7 +8,9 @@ import {
 import flat from 'array.prototype.flat';
 import { getTyping } from './registry.js';
 import {
-  getWhitelistBlacklistConfig, Mutate, postProcessGQLValue,
+  getWhitelistBlacklistConfig,
+  Mutate,
+  postProcessGQLOutput,
   preProcessGQLInput,
 } from './graphql.js';
 import {
@@ -27,7 +29,7 @@ import {
 import { ReadRequest } from '@restorecommerce/rc-grpc-clients';
 import {
   Filter_Operation,
-  Filter_ValueType, FilterOp_Operator
+  Filter_ValueType
 } from '@restorecommerce/rc-grpc-clients/dist/generated/io/restorecommerce/resource_base.js';
 import { type DescriptorProto, type ServiceDescriptorProto } from 'ts-proto-descriptors';
 import { type GraphQLResolveInfo } from 'graphql';
@@ -196,7 +198,7 @@ export const getGQLResolverFunctions = <
               'origin-ip': contextRequest.client.address().address
             })
           });
-          const result = postProcessGQLValue(rawResult, outputTyping.output);
+          const result = postProcessGQLOutput(rawResult, outputTyping.output);
 
           const grpcClientConfig = cfg.client;
           const bufferFields = getKeys((grpcClientConfig as any)?.bufferFields);

diff --git a/packages/facade/tests/protos.spec.ts b/packages/facade/tests/protos.spec.ts
@@ -1,8 +1,12 @@
 import {
   protoMetadata,
 } from '@restorecommerce/rc-grpc-clients/dist/generated/io/restorecommerce/order.js';
+import {
+  Meta
+} from '@restorecommerce/rc-grpc-clients/dist/generated/io/restorecommerce/meta.js';
 import { GraphQLList, GraphQLNonNull, GraphQLObjectType, GraphQLScalarType } from 'graphql';
 import { getTyping, registerPackagesRecursive } from '../src/gql/protos/index.js';
+import { preProcessGQLInput, postProcessGQLOutput } from '../src/gql/protos/graphql.js'
 
 describe('proto-meta', () => {
   it('should register typings', () => {
@@ -33,4 +37,24 @@ describe('proto-meta', () => {
 
     expect(fields.meta.type).toEqual(getTyping('.io.restorecommerce.meta.Meta')!.output);
   });
+
+  it('should pre/post-process input/output correctly', async () =>{
+    const model = getTyping('.io.restorecommerce.meta.Meta');
+    const input: Meta = {
+      created: new Date(),
+      createdBy: 'user',
+      owners: [
+        {
+          id: 'some-type-identifier',
+          value: 'user'
+        }
+      ],
+      acls: null,
+    };
+
+    const preProcessed = await preProcessGQLInput(input, model.input);
+    const postProcessed = postProcessGQLOutput(preProcessed, model.output);
+
+    expect(preProcessed).toEqual(postProcessed);
+  })
 });