chore: refactor all tests

packages/acs-client/.gitignore

@@ -19,3 +19,4 @@ test/*.js
 test/*.d.ts
 !.eslintrc.js
 !setupTopics.js
+coverage/

packages/acs-client/cfg/config_test.json

@@ -2,9 +2,9 @@
   "logger": {
     "console": {
       "handleExceptions": false,
-      "level": "error",
+      "level": "silly",
       "colorize": true,
       "prettyPrint": true
     }
   }
-}
+}

packages/acs-client/package.json

@@ -36,36 +36,28 @@
     "@restorecommerce/protos": "^6.8.11",
     "@types/eslint__js": "^8.42.3",
     "@types/koa": "^2.15.0",
-    "@types/mocha": "^10.0.9",
     "@types/node": "^22.7.9",
     "@types/redis": "^4.0.2",
-    "coveralls": "^3.1.1",
     "cross-env": "^7.0.3",
     "eslint": "^9.12.0",
     "eslint-plugin-prefer-arrow-functions": "^3.4.1",
-    "mocha": "^10.7.3",
     "nice-grpc": "^2.1.10",
     "nodemon": "^3.1.7",
     "npm-run-all": "^4.1.5",
-    "nyc": "^17.1.0",
     "rimraf": "^6.0.1",
     "should": "^13.2.3",
     "ts-node": "^10.9.1",
     "typescript": "^5.6.2",
-    "typescript-eslint": "8.11.0"
+    "typescript-eslint": "8.11.0",
+    "vitest": "^2.1.4"
   },
   "scripts": {
     "build:tsc": "tsc -d",
     "build:tsc:watch": "tsc -d --watch",
     "build:clean": "rimraf lib",
     "build": "npm-run-all lint build:clean build:tsc",
     "lint": "eslint src",
-    "test": "npm run build && nyc npm run mocha && npm run mocha:cache",
-    "mocha": "cross-env NODE_ENV=test mocha --full-trace --exit --timeout 30000",
-    "mocha:cache": "cross-env NODE_ENV=test CACHE_ENABLED=true mocha --full-trace --exit --timeout 30000",
-    "test-debug": "npm run mocha -- --inspect-brk",
-    "lcov-report": "nyc report --reporter=lcov",
-    "coveralls": "nyc report --reporter=text-lcov | coveralls"
+    "test": "npm run build && cross-env NODE_ENV=test vitest run && cross-env NODE_ENV=test CACHE_ENABLED=true vitest run"
   },
   "nx": {
     "targets": {

packages/acs-client/test/acs.spec.test.ts

@@ -1,7 +1,6 @@
-import { } from 'mocha';
 import * as should from 'should';
-import { accessRequest, isAllowed, whatIsAllowed } from '../lib/acs/resolver';
-import { flushCache, initializeCache } from '../lib/acs/cache';
+import { accessRequest, isAllowed, whatIsAllowed } from '../src/acs/resolver';
+import { flushCache, initializeCache } from '../src/acs/cache';
 import {
   AuthZAction,
   DecisionResponse,
@@ -10,17 +9,18 @@ import {
   ACSClientContext,
   CtxResource,
   RuleRQ,
-} from '../lib/acs/interfaces';
-import { initAuthZ, ACSAuthZ } from '../lib/acs/authz';
-import logger from '../lib/logger';
+} from '../src/acs/interfaces';
+import { initAuthZ, ACSAuthZ } from '../src/acs/authz';
+import logger from '../src/logger';
 import * as _ from 'lodash';
-import { cfg } from '../lib';
+import { cfg } from '../src';
 import {
   Request,
   Response_Decision
 } from '@restorecommerce/rc-grpc-clients/dist/generated-server/io/restorecommerce/access_control';
 import { GrpcMockServer } from '@alenon/grpc-mock-server';
 import { Effect } from '@restorecommerce/rc-grpc-clients/dist/generated-server/io/restorecommerce/rule';
+import { it, describe, beforeAll, afterAll, beforeEach, afterEach } from 'vitest';
 
 let authZ: ACSAuthZ;
 
@@ -320,16 +320,15 @@ const stop = async (): Promise<void> => {
 };
 
 describe('Testing acs-client', () => {
-  before(async function startServer(): Promise<void> {
-    this.timeout(60000);
+  beforeAll(async () => {
     const cacheEnabled = process.env.CACHE_ENABLED;
     if (cacheEnabled && cacheEnabled.toLowerCase() === 'true') {
       await initializeCache();
     }
     await start();
-  });
+  }, 60000);
 
-  after(async (): Promise<void> => {
+  afterAll(async () => {
     await stop();
     const cacheEnabled = process.env.CACHE_ENABLED;
     if (cacheEnabled && cacheEnabled.toLowerCase() === 'true') {

packages/acs-client/test/acs_multiple_entities.spec.test.ts

@@ -1,11 +1,10 @@
-import { } from 'mocha';
 import * as should from 'should';
 import {
   accessRequest,
   isAllowed,
   whatIsAllowed
-} from '../lib/acs/resolver';
-import { flushCache, initializeCache } from '../lib/acs/cache';
+} from '../src/acs/resolver';
+import { flushCache, initializeCache } from '../src/acs/cache';
 import {
   AuthZAction,
   DecisionResponse,
@@ -14,8 +13,8 @@ import {
   ACSClientContext,
   CtxResource,
 } from '../lib/acs/interfaces';
-import { initAuthZ, ACSAuthZ } from '../lib/acs/authz';
-import logger from '../lib/logger';
+import { initAuthZ, ACSAuthZ } from '../src/acs/authz';
+import logger from '../src/logger';
 import * as _ from 'lodash';
 import {
   MultiplePolicySetRQFactory,
@@ -36,6 +35,7 @@ import {
   Response_Decision
 } from '@restorecommerce/rc-grpc-clients/dist/generated-server/io/restorecommerce/access_control';
 import { GrpcMockServer } from '@alenon/grpc-mock-server';
+import { it, describe, beforeAll, afterAll, beforeEach, afterEach } from 'vitest';
 
 let authZ: ACSAuthZ;
 
@@ -167,16 +167,15 @@ const subject = {
 };
 
 describe('testing acs-client with multiple entities', () => {
-  before(async function startServer(): Promise<void> {
-    this.timeout(60000);
+  beforeAll(async () => {
     const cacheEnabled = process.env.CACHE_ENABLED;
     await start();
     if (cacheEnabled?.toLowerCase() === 'true') {
       await initializeCache();
     }
-  });
+  }, 60000);
 
-  after(async (): Promise<void> => {
+  afterAll(async () => {
     await stop();
     const cacheEnabled = process.env.CACHE_ENABLED;
     if (cacheEnabled?.toLowerCase() === 'true') {

packages/acs-client/test/rules_utils.ts

@@ -1,6 +1,6 @@
 import { Effect } from '@restorecommerce/rc-grpc-clients/dist/generated-server/io/restorecommerce/rule';
 import { ReverseQuery } from '@restorecommerce/rc-grpc-clients/dist/generated-server/io/restorecommerce/access_control';
-import { RuleRQ } from '../lib';
+import { RuleRQ } from '../src';
 import { Attribute } from '@restorecommerce/rc-grpc-clients/dist/generated-server/io/restorecommerce/attribute';
 
 export const permitLocationRule = {

packages/acs-client/tsconfig-base.json

@@ -2,7 +2,7 @@
     "extends": "../../node_modules/@restorecommerce/dev/tsconfig.json",
     "compilerOptions": {
       "outDir": "./lib",
-      "types": ["node", "jest"],
+      "types": ["node"],
       "resolveJsonModule": true
     },
     "exclude": [
@@ -11,4 +11,3 @@
       "doc"
     ]
   }
-

packages/acs-client/vitest.config.ts

@@ -0,0 +1,2 @@
+import config from '../../node_modules/@restorecommerce/dev/vitest.config.js';
+export default config;

packages/cluster-service/package.json

@@ -20,18 +20,13 @@
     "recluster": "^1.0.0"
   },
   "devDependencies": {
-    "coveralls": "^3.1.1",
     "is-generator": "^1.0.3",
-    "mocha": "^10.2.0",
-    "nyc": "17.1.0",
-    "should": "^13.2.3"
+    "should": "^13.2.3",
+    "vitest": "^2.1.4"
   },
   "scripts": {
-    "test": "nyc mocha --full-trace --exit",
-    "lint": "eslint *.json *.js",
-    "mocha": "mocha ./test/*",
-    "lcov-report": "nyc report --reporter=lcov",
-    "coveralls": "nyc report --reporter=text-lcov | coveralls"
+    "test": "vitest run --dangerouslyIgnoreUnhandledErrors",
+    "lint": "eslint *.json *.js"
   },
   "engines": {
     "node": ">= 10.0.0"

packages/cluster-service/test/test.js → packages/cluster-service/test/core.test.js

@@ -1,20 +1,19 @@
 const ClusterServer = require('../index');
+import { it, describe } from 'vitest';
 
 const prodOptions = {
   mode: 'production'
 };
 
 describe('the cluster service', function() {
-  it('should be able to start a server in development mode', function(done) {
+  it('should be able to start a server in development mode', () => {
     const cluster = new ClusterServer();
     cluster.run('./test/service.js');
     cluster.stop();
-    done();
   });
-  it('should be able to start a server in production mode', function(done) {
+  it('should be able to start a server in production mode', () => {
     const cluster = new ClusterServer(prodOptions);
     cluster.run('./test/service.js');
     cluster.stop();
-    done();
   });
 });

packages/cluster-service/vitest.config.ts

@@ -0,0 +1,2 @@
+import config from '../../node_modules/@restorecommerce/dev/vitest.config.js';
+export default config;

packages/dev/eslint.config.js

@@ -4,6 +4,7 @@ import fileExtensionInImportTS from 'eslint-plugin-file-extension-in-import-ts';
 import tsParser from '@typescript-eslint/parser';
 import { plugin as tesLintPlugin } from 'typescript-eslint';
 import { fixupPluginRules } from "@eslint/compat";
+import stylistic from '@stylistic/eslint-plugin';
 
 export default [
   {
@@ -29,7 +30,8 @@ export default [
       '@typescript-eslint': tesLintPlugin,
       'prefer-arrow-functions': fixupPluginRules(preferArrowFunctions),
       'unicorn': unicorn,
-      'file-extension-in-import-ts': fileExtensionInImportTS
+      'file-extension-in-import-ts': fileExtensionInImportTS,
+      '@stylistic': stylistic
     },
     rules: {
       '@typescript-eslint/adjacent-overload-signatures': 'error',
@@ -44,8 +46,8 @@ export default [
           'format': ['PascalCase']
         }
       ],
-      '@typescript-eslint/indent': ['error', 2],
-      '@typescript-eslint/member-delimiter-style': [
+      '@stylistic/indent': ['error', 2],
+      '@stylistic/member-delimiter-style': [
         'error',
         {
           'multiline': {
@@ -61,11 +63,11 @@ export default [
       '@typescript-eslint/no-inferrable-types': 'error',
       '@typescript-eslint/no-use-before-define': [2, {'functions': true, 'classes': true}],
       '@typescript-eslint/prefer-namespace-keyword': 'error',
-      '@typescript-eslint/semi': [
+      '@stylistic/semi': [
         'error',
         'always'
       ],
-      '@typescript-eslint/type-annotation-spacing': 'error',
+      '@stylistic/type-annotation-spacing': 'error',
       'arrow-parens': [
         'off',
         'as-needed'

packages/dev/package.json

@@ -15,9 +15,15 @@
   ],
   "type": "module",
   "dependencies": {
+    "@eslint/compat": "^1.0.3",
+    "@stylistic/eslint-plugin": "^2.10.1",
+    "@typescript-eslint/eslint-plugin": "8.10.0",
+    "@typescript-eslint/parser": "8.10.0",
     "@vitest/coverage-v8": "^2.1.4",
     "eslint": "^9.12.0",
+    "eslint-plugin-file-extension-in-import-ts": "^2.1.0",
     "eslint-plugin-prefer-arrow-functions": "^3.4.1",
+    "eslint-plugin-unicorn": "56.0.0",
     "typescript-eslint": "8.11.0",
     "vitest": "^2.1.4"
   },

packages/dev/vitest.config.ts

@@ -3,6 +3,8 @@ import { defineConfig } from 'vitest/config';
 export default defineConfig({
   test: {
     globals: true,
+    fileParallelism: false,
+    testTimeout: 60000,
     coverage: {
       enabled: true,
       provider: 'v8',