Skip to content

fix(drop,click): prevent adding nodes if the addition is unsuccessful #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ni55aN merged 1 commit into from
Apr 27, 2025
Merged

fix(drop,click): prevent adding nodes if the addition is unsuccessful #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/click-strategy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,12 @@ export class ClickStrategy<K> implements Strategy {
element.addEventListener('click', async () => {
const node = create()

await this.editor.addNode(node)
const added = await this.editor.addNode(node)

if (!added) {
console.warn('Node addition prevented:', node)
return
}

const viewportCenter = this.getViewportCenter()
const view = this.area.nodeViews.get(node.id)
Expand Down
7 changes: 6 additions & 1 deletion src/drop-strategy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,12 @@ export class DropStrategy<K> implements Strategy {
}

private async drop(node: BaseSchemes['Node'], position: Position) {
await this.editor.addNode(node)
const added = await this.editor.addNode(node)

if (!added) {
console.warn('Node addition prevented:', node)
return
}

const view = this.area.nodeViews.get(node.id)

Expand Down
Loading