Fix: ST1023: should omit type Err from declaration #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@majst01 Sorry, extremely late reply! I'm going to review the PR this week! |
Hi @gabor-boros no worries :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @gabor-boros
me again, had some spare time and spent it to fix some obvious linter complains.
Please have a look if your time allows.
Reason for the change
golangci-lint staticcheck complains that in variable declarations, the lefthand side is not necessary, fix this.
Description
A clear and concise description of what did you changed and why.
Code examples
If applicable, add code examples to help explain your changes.
Checklist
References
Anything else related to the change e.g. documentations, RFCs, etc.