Resolve nameserver and MX details in the DNS tab and JSON#60
Merged
Conversation
Generic hostname -> A/AAAA -> reverse-DNS resolver using the configured resolver, returning all PTR names per address. Extracted so both MX and NS resolution can share it, and structured behind a small resolver interface so the logic is unit-testable without real DNS. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add "i resolve ns" on the DNS tab, mirroring the existing "i resolve mx" on the Mail tab: it lists the IPv4/IPv6 addresses and reverse DNS for each nameserver, toggling expand/collapse. Migrate the old mail-specific MX resolution onto the shared dnsutil.ResolveHosts, dropping the duplicated ResolveMX/MXResolution/MXIP from the mail package. Add MXResolved/NSResolved fields to the record types so the resolved data can be surfaced beyond the TUI. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The IP/PTR data shown by "i resolve mx"/"i resolve ns" in the TUI was not available in JSON output. Add an opt-in --resolve flag to the dns, mail and all commands that populates NSResolved/MXResolved with each host's addresses and reverse DNS. It is opt-in so the default output stays fast and avoids the extra per-host lookups. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
i resolve nson the DNS tab, mirroringi resolve mx— it lists the IPv4/IPv6 addresses and reverse DNS (PTRs) for each nameserver. The MX/NS resolution logic is now a shareddnsutil.ResolveHostshelper rather than a mail-specific one.The IP/PTR data shown by
i resolvewas previously TUI-only, so a--resolveflag is added to thedns,mail, andallcommands that includes it in JSON via newNSResolved/MXResolvedfields. It's opt-in to keep the default output fast and avoid the extra per-host lookups.Close #58