PR change the location of bytebuf modification methods from PacketWrapper to a seperate exposed API #860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR Is not yet complete, this is just an example of how the API would be introduced to packetevents |
retrooper
approved these changes
Aug 12, 2024
|
When will this be added? |
|
It's not complete, and it's still marked as a draft? |
|
Pr back to being actively worked on |
Tofaa2
commented
May 26, 2025
| return type.read(this); | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
@retrooper Do you think these should be kept as methods in here or static BinaryBufferType<?> creation methods. Same with map and collection and primitive arrays with varint size prefix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to replace the PacketWrapper#readSomething and PacketWrapper#writeSomething with a more scalable and convenient API. Seperating types and no longer depending on Object for everything in PacketWrapper that is meant to be ByteBuf (kinda)