fix: use POST method for token request #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrytrager
force-pushed
the
fix/post-request-for-token
branch
from
88bfc21 to
675d3ae
Compare
dmitrytrager
force-pushed
the
fix/post-request-for-token
branch
3 times, most recently
from
7eb9902 to
c07f413
Compare
AlphaB
reviewed
Jan 16, 2025
lib/panda.rb
Outdated
| connection = Faraday.new do |conn| | ||
| conn.use Panda::ErrorMiddleware | ||
| conn.request :json | ||
| conn.response :json | ||
| end | ||
|
|
||
| response = connection.get(request.url, request.params, request.headers) | ||
| response = do_request(connection, request) |
There was a problem hiding this comment.
We can use connection.run_request(request.method, request.url, request.body, request.headers), it's more flexible in case we will need to add more HTTP methods
dmitrytrager
force-pushed
the
fix/post-request-for-token
branch
from
c07f413 to
e79c5ea
Compare
AlphaB
reviewed
Jan 17, 2025
lib/panda.rb
Outdated
| Panda::HTTPResponse.new(response.status, response.headers, response.body) | ||
| end | ||
|
|
||
| def do_request(connection, request) |
dmitrytrager
force-pushed
the
fix/post-request-for-token
branch
from
e79c5ea to
50cb98d
Compare
AlphaB
reviewed
Jan 17, 2025
AlphaB
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It happened that token info get request uses POST method. This PR fixes method mismatch