validate does not check all the files at once

[victornoel]

When I run the validate goal, it fails at the first problematic file instead of showing me all the files that fail.

If the objective is to use it in the CI for example, this is very limiting to only show one error…

[hazendaz]

Not really. It simply means formatting was not run. So when CI fails, developer should run a proper build and commit the result which may be many files. Get Outlook for Android<https://aka.ms/ghei36>

…

________________________________ From: Victor Noël <[email protected]> Sent: Friday, February 16, 2018 5:06:55 AM To: revelc/formatter-maven-plugin Cc: Subscribed Subject: [revelc/formatter-maven-plugin] validate does not check all the files at once (#270) When I run the validate goal, it fails at the first problematic file instead of showing me all the files that fail. If the objective is to use it in the CI for example, this is very limiting to only show one error… — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<#270>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AA7ho9FXwJQ03LAYdUVhTBlJ83x0DJ62ks5tVVM-gaJpZM4SIG6M>.

[victornoel]

I understand that, but it would be nicer if we could get all at once: even locally, it is tedious to run validate one file per one file to correct each of them.

It is not always possible to use eclipse's formatting on a whole project, for example if one configure some exclusions from the validation.

[hazendaz]

I understand, generally though that is not intended for local runs. It's just to stop CI if user forgot to run a full build. Technically speaking both validate and format should be the same and if using in CI system, you would want it configured to always run format locally and validate on CI. Where CI is important there is that this does not run on it's own in eclipse or other IDE's so when user modifies a file then doesn't run a full cycle maven build, the file will not be formatted. While there is a plugin for m2e to make that work in eclipse, manual setup has classloading leaks and I've found no good way around that.

I agree getting full list of files that should format could be useful even from CI to show the scope of overall issue. If you have some time, it would be great if you could submit a pull request that will address this issue.