Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft] Solution for issue 270 to show all validation errors #644

Closed
wants to merge 1 commit into from

Conversation

hazendaz
Copy link
Member

Initial attempt at fixing #270. This is draft to gather input for feedback of supporting this feature. It does not have an integration test but steps to test are below.

To test

  • Checkout branch
  • Run build to generate local snapshot for test usage
  • Add extra spacing to 2 or more files
  • Run 'mvn net.revelc.code.formatter:formatter-maven-plugin:2.20.0-SNAPSHOT:validate' which will show new behavior of split from output of first file detected that violates formatting rules.
  • Run mvn net.revelc.code.formatter:formatter-maven-plugin:2.20.0-SNAPSHOT:validate -D"formatter.failOnFirstValidationError=false" which will show multiple files in violation.

@hazendaz hazendaz requested a review from ctubbsii July 16, 2022 23:57
Copy link
Member

@ctubbsii ctubbsii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach seems reasonable. I like that it defaults to fast failure, which is the current behavior. It might be nice if the batch report of failures could be saved in a file in the target directory.

@hazendaz
Copy link
Member Author

Thanks, thinking this would come post 2022-06 release with target around 2022-09 given still need to build out IT tests and batch report file consideration.

@ctubbsii ctubbsii added this to the 2.21.0 milestone Sep 29, 2022
@ctubbsii
Copy link
Member

@hazendaz 2022-09 is out. Wasn't sure if you had time to revisit this, so we could include it. No rush, though. I figure we could wrap up 2.21 for October for 2022-09.

@hazendaz
Copy link
Member Author

hazendaz commented Sep 30, 2022 via email

@ctubbsii ctubbsii modified the milestones: 2.21.0, 2.22.0 Nov 4, 2022
@ctubbsii ctubbsii modified the milestones: 2.22.0, 2.23.0 Feb 6, 2023
@hazendaz hazendaz closed this Mar 13, 2023
@ctubbsii ctubbsii removed this from the 2.23.0 milestone Mar 13, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants