Update for Eclipse 2023-12 #812
Conversation
|
Seems ok to me but does mean we are raising jdk requirements. Please do update the requirement here as this won't work with jdk 11. The internals already state as much. If I recall we didn't even bother releasing the last one as a result. Plus there were issues with static imports with mockito 'when' that were entirely broken. The caching is also still broken but that isn't relevant to this upgrade. With the community as a whole mainly starting with spring forcing java 17 on everyone and now jakarta forcing at least 21 and tomcat, either accidentally or on purpose forcing jdk 22, we have no option but to drop old users. |
| @@ -325,7 +325,7 @@ | |||
| <!-- bump this and run src/build/find-transitive-eclipse-updates.sh to update eclipse deps --> | |||
| <groupId>org.eclipse.jdt</groupId> | |||
| <artifactId>org.eclipse.jdt.core</artifactId> | |||
| <version>3.33.0</version> | |||
| <version>3.36.0</version> | |||
There was a problem hiding this comment.
Yah , mockito 'when' static usage is now fixed.
|
Just a note to add, from my fork which is using enforcer plugin separately to show the jdk requirement. PR is good now, will merge. |
Version 2.24.0 will require JDK 17, so this change makes it the runtime target version, so that it explicitly requires JDK 17, for fast failure and errors don't show up later unexpectedly when calling into the Eclipse libraries at runtime. Also update the README. Notably, the website docs were already updated to indicate it is required as part of the PR revelc#812
|
I think there was something missing here. I added it in #826 . I also updated the parent POM that I've been working on to help clean up and simplify the maintenance of this and other projects in revelc (especially to get dependabot spam under control). I added a profile to do the byte code checking in version 6 of the parent POM (revelc/revelc@f178fe8), but version 6 isn't released yet. I did test it with these changes, and with #826 to confirm that #826 closes the gap and makes JDK 17 a strict requirement. |
|
Re: dropping old users. If there's a bugfix needed for 2.23, we can still patch it for users on JDK 11. However, it's likely that users will just stick with the old version as-is until they are ready to jump to JDK 17 (at least for builds, if not for runtime). |
Version 2.24.0 will require JDK 17, so this change makes it the runtime target version, so that it explicitly requires JDK 17, for fast failure and errors don't show up later unexpectedly when calling into the Eclipse libraries at runtime. Also update the README. Notably, the website docs were already updated to indicate it is required as part of the PR #812
|
Sounds good!
Sent from my Verizon, Samsung Galaxy smartphone
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Christopher Tubbs ***@***.***>
Sent: Monday, January 22, 2024 6:58:46 PM
To: revelc/formatter-maven-plugin ***@***.***>
Cc: Jeremy Landis ***@***.***>; Assign ***@***.***>
Subject: Re: [revelc/formatter-maven-plugin] Update for Eclipse 2023-12 (PR #812)
Re: dropping old users. If there's a bugfix needed for 2.23, we can still patch it for users on JDK 11. However, it's likely that users will just stick with the old version as-is until they are ready to jump to JDK 17 (at least for builds, if not for runtime).
—
Reply to this email directly, view it on GitHub<#812 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAHODI3ILRE6MRODZNPVUJ3YP34LNAVCNFSM6AAAAABAN2RH42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBVGA2DMOJSHE>.
You are receiving this because you were assigned.Message ID: ***@***.***>
|
I hope I did everything correctly☺️