[894] Use the formattedCode for the formattedHash. #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamezp
commented
Jun 3, 2024
| @@ -792,7 +792,7 @@ protected void doFormatFile(final File file, final ResultCollector rc, final Pro | |||
|
|
|||
| // Process the result type | |||
| if (Result.SKIPPED.equals(result)) { | |||
| rc.unchangedCount++; | |||
| rc.skippedCount++; | |||
There was a problem hiding this comment.
I wasn't sure if this line should be changed or not. I changed it for testing and forgot to revert it before committing. If this change should be removed, please let me know.
There was a problem hiding this comment.
Change it back for purpose of this pull request. I do want to look more at this part after as it's still confusing on naming.
There was a problem hiding this comment.
Updated. Sorry about that, I should have just done it last night :)
resolves revelc#894 Signed-off-by: James R. Perkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #894