-
-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor doghouse / github-[pr-]check related code #1798
base: master
Are you sure you want to change the base?
Conversation
1. Implement GitHub Check API flow as CommentService / DiffService 2. Use the above {Comment,Diff}Service if reviewdog won't talk to the doghouse server 3. Implement github-pr-annotations reporter as {Comment,Diff}Service 4. It means doghouse related code should be used only when reviewdog needs to talk to the doghouse server
454aea7
to
6e70db3
Compare
f6ee89c
to
b8b64ff
Compare
--- Range | ||
a = 10 | ||
a = 11 | ||
b = 20 | ||
c = 30 | ||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[custom-rdjson] reported by reviewdog 🐶
range test 1 (line only)
a = 11 | ||
b = 20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[custom-rdjson] reported by reviewdog 🐶
range test 3 (with line-break)
a = 11 | ||
b = 20 | ||
c = 30 | ||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[custom-rdjson] reported by reviewdog 🐶
range test 4 (with line-break)
--- Range | ||
a = 10 | ||
a = 11 | ||
b = 20 | ||
c = 30 | ||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[custom-rdjson] reported by reviewdog 🐶
range test 1 (line only)
a = 11 | ||
b = 20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[custom-rdjson] reported by reviewdog 🐶
range test 3 (with line-break)
a = 11 | ||
b = 20 | ||
c = 30 | ||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[custom-rdjson] reported by reviewdog 🐶
range test 4 (with line-break)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: ICHINOSE Shogo <[email protected]>
the doghouse server (reviewdog GitHub App)
needs to talk to the doghouse server