Skip to content

resolve #1213 and #1193#1243

Merged
EdenWuyifan merged 4 commits into
devfrom
ew/bugfixes
Jun 9, 2026
Merged

resolve #1213 and #1193#1243
EdenWuyifan merged 4 commits into
devfrom
ew/bugfixes

Conversation

@EdenWuyifan

@EdenWuyifan EdenWuyifan commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Does this PR close any open issues?

Closes #1213
Closes #1193.

Give a longer description of what this PR addresses and why it's needed

Resolve #1213 and #1193.

  • Add an optionalProperty for metadata tidy CSV download.
  • Add a little footnote on the bottom right corner of the landing page showing ReVISiT version.

Provide pictures/videos of the behavior before and after these changes (optional)

#1193 - add an optionalProperties that covers keys under metadata:
图片

#1213 - add a small version tag on the landing page:
图片

Are there any additional TODOs before this PR is ready to go?

TODOs:

  • Update relevant documentation
  • ...

@EdenWuyifan EdenWuyifan requested a review from jaykim1213 June 3, 2026 07:32
@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

🪓 PR closed, deleted preview.

@EdenWuyifan EdenWuyifan linked an issue Jun 3, 2026 that may be closed by this pull request
@EdenWuyifan EdenWuyifan changed the title resolves #1213 and #1193 resolve #1213 and #1193 Jun 4, 2026
@JackWilb JackWilb changed the base branch from main to dev June 4, 2026 15:12
@JackWilb

JackWilb commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

@EdenWuyifan
The version tag looks great, but please use the maximum revisit version from the studies that are referenced from the global.json.
Please update the metaData to output to a row instead of a column. You can follow the participantTags as an example of how to do this.

Thanks!

@EdenWuyifan

Copy link
Copy Markdown
Contributor Author

Hi @JackWilb, thanks for the reviews -- please take a look at the newest commit.

@EdenWuyifan EdenWuyifan requested a review from JackWilb June 6, 2026 05:28
@alexsb

alexsb commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

We could bump up the font size a bit; and maybe even move it into the header toolbar?

@EdenWuyifan

Copy link
Copy Markdown
Contributor Author

We could bump up the font size a bit; and maybe even move it into the header toolbar?

Hi @alexsb, done :)
Now the verson tag is slightly bigger and all the logics are in AppHeader.

@JackWilb JackWilb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @EdenWuyifan

@EdenWuyifan EdenWuyifan merged commit 6a7d8c7 into dev Jun 9, 2026
5 of 7 checks passed
@EdenWuyifan EdenWuyifan deleted the ew/bugfixes branch June 9, 2026 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ReVISit experiment landing page should show the version somewhere Make metadata available in the downloaded CSV file

3 participants