Skip to content

Add verification pass for unresolved React components#1289

Open
WilsonGramer wants to merge 1 commit into
revisit-studies:devfrom
WilsonGramer:verify-unresolved-react-components
Open

Add verification pass for unresolved React components#1289
WilsonGramer wants to merge 1 commit into
revisit-studies:devfrom
WilsonGramer:verify-unresolved-react-components

Conversation

@WilsonGramer

Copy link
Copy Markdown

Does this PR close any open issues?

I couldn't find a related issue, but this is a feature request from Lane (@codementum).

Give a longer description of what this PR addresses and why it's needed

This PR adds a pass to verifyStudyConfig that checks whether imported React components exist in src/public/. It uses the same logic to fetch modules as ReactComponentController.tsx. If the module doesn't exist, it suggests to check that the component is in src/public/ and not public/.

Provide pictures/videos of the behavior before and after these changes (optional)

In demo-react-trrack/config.json, changing the component name to Missing.tsx produces this error:

verify-unresolved-react-components

Are there any additional TODOs before this PR is ready to go?

TODOs:

  • Other component types?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant