Merge pull request #643 from revolist/filter-hooks

docs: typing and comments
revolist · Nov 28, 2024 · 93978cb · 93978cb
2 parents 89a75ad + faaf594
commit 93978cb
Show file tree

Hide file tree

Showing 9 changed files with 16 additions and 16 deletions.
diff --git a/docs b/docs
diff --git a/formats/select b/formats/select
diff --git a/packages/angular b/packages/angular
diff --git a/packages/react b/packages/react
diff --git a/packages/svelte b/packages/svelte
diff --git a/packages/vue2 b/packages/vue2
diff --git a/packages/vue3 b/packages/vue3
diff --git a/src/components/overlay/autofill.service.tsx b/src/components/overlay/autofill.service.tsx
@@ -262,10 +262,10 @@ export class AutoFillService {
   /**
    * Trigger range apply events and handle responses
    */
-  onRangeApply(data: DataLookup, range: RangeArea | null) {
+  onRangeApply(newData: DataLookup, range: RangeArea | null) {
     this.sv.rangeDataApply({
-      data,
-      models: collectModelsOfRange(data, this.sv.dataStore),
+      data: newData,
+      models: collectModelsOfRange(newData, this.sv.dataStore),
       type: this.sv.dataStore.get('type'),
     });
 

diff --git a/src/types/selection.ts b/src/types/selection.ts
@@ -55,11 +55,11 @@ export type TempRange = {
   area: RangeArea;
 };
 export type OldNewRangeMapping = {
-  [rowIndex: number]: {
-    [T in ColumnProp]: {
-      rowIndex: number;
-      colIndex: number;
-      colProp: ColumnProp;
+  [newRowIndex: number]: {
+    [T in ColumnProp]: { // new column prop
+      rowIndex: number; // original row
+      colIndex: number; // original col
+      colProp: ColumnProp; // original column prop
     };
   };
 };
@@ -70,7 +70,7 @@ export type ChangedRange = {
   oldRange: RangeArea; // range to copy from
   mapping: OldNewRangeMapping;
   newData: {
-    [key: number]: DataType;
+    [newRowIndex: number]: DataType;
   };
 };