-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Transfer ownership #396
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: LazyCat2 <[email protected]>
Signed-off-by: LazyCat2 <[email protected]>
As mentioned in the comment I put in the RFC PR, it would be better to check if the user has 2FA enabled before allowing them to transfer servers. That way any account which does not have 2FA enabled will not be allowed to transfer servers, preventing future abuse/malicious activity. |
If hacker gets access to account, they can just enable mfa, if it is not enabled already, so i do not think this check will add any security |
You need the account's password to enable 2FA/MFA. If a hacker gains access to an account, it would most likely be via token rather than password. How can someone enable 2FA if they don't have the password? |
Ill try to add it later then |
👍🏻 |
Signed-off-by: LazyCat2 <[email protected]>
Signed-off-by: LazyCat2 <[email protected]>
Please make sure to check the following tasks before opening and submitting a PR
Closes #196
RFC PR: #14