Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translations for README files and miners #1858

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Leadernelson
Copy link

Fixes #877

Add French, Vietnamese, and Dutch translations for the README file.

  • Add Resources/README_TRANSLATIONS/README_fr_FR.md for French translation.
  • Add Resources/README_TRANSLATIONS/README_vi_VN.md for Vietnamese translation.
  • Add Resources/README_TRANSLATIONS/README_nl_NL.md for Dutch translation.
  • Update Resources/README_TRANSLATIONS/README_ja_JP.md for Japanese translation.
  • Update Resources/README_TRANSLATIONS/README_de_DE.md for German translation.
  • Update Resources/AVR_Miner_langs.json for German translation of the AVR Miner.

Fixes revoxhere#877

Add French, Vietnamese, and Dutch translations for the README file.

* Add `Resources/README_TRANSLATIONS/README_fr_FR.md` for French translation.
* Add `Resources/README_TRANSLATIONS/README_vi_VN.md` for Vietnamese translation.
* Add `Resources/README_TRANSLATIONS/README_nl_NL.md` for Dutch translation.
* Update `Resources/README_TRANSLATIONS/README_ja_JP.md` for Japanese translation.
* Update `Resources/README_TRANSLATIONS/README_de_DE.md` for German translation.
* Update `Resources/AVR_Miner_langs.json` for German translation of the AVR Miner.
@jpx13
Copy link

jpx13 commented Feb 1, 2025

Some translation errors in the French version.
Did you use an ai to translate ?
I can review and make necessary changes.

@Leadernelson
Copy link
Author

Yes it is AI (GitHub copilot). Sorry, I did not ask if it was permitted.

@jpx13
Copy link

jpx13 commented Feb 1, 2025

Overall not bad, but it is obvious it was not written by a French human :)
Also in the software list, there are spanish words in the middle of some sentences.
I will check and correct tomorrow if i Can find some time.
Then Revox will have to validite your PR

@jpx13
Copy link

jpx13 commented Feb 4, 2025

I Reviewed the Fr translation and made some slight changes...
Changes are on the OP github, not in this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translation Requests
2 participants