fix example

rformassspectrometry · Dec 4, 2024 · 666172f · 666172f
1 parent c6bd03c
commit 666172f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/R/Spectra.R b/R/Spectra.R
@@ -1676,7 +1676,7 @@ setReplaceMethod("[[", "Spectra", function(x, i, j, ..., value) {
 #' spectraData(sciex2)[1:13, c("spectrumId", "var1", "var2")]
 #'
 #' ## Append new spectra variables with cbind2()
-#' df <- data.frame(cola = 4:5, colb = "b")
+#' df <- data.frame(cola = seq_len(length(sciex1)), colb = "b")
 #' data_append <- cbind2(sciex1, df)
 NULL
 

diff --git a/inst/test_backends/test_MsBackend/test_spectra_subsetting.R b/inst/test_backends/test_MsBackend/test_spectra_subsetting.R
@@ -70,6 +70,12 @@ test_that("cbind2 works", {
     expect_equal(res$colz, rep("z", seql))
     df2  <- data.frame(cola = 3:6, colb = "b", colz = "z")
     expect_error(cbind2(be, df2), "does not match")
+    ## with matrix
+    m <- matrix(1:seql, ncol = 1, dimnames = list(NULL, "m"))
+    res <- cbind2(be, m)
+    expect_true(validObject(res))
+    expect_equal(ncol(spectraData(res)), length(spectraVariables(be)) + 1)
+    expect_equal(res$m, 1:seql)
 })
 
 #' extractByIndex. Uses [ if not implemented

diff --git a/man/combineSpectra.Rd b/man/combineSpectra.Rd