Add a method to change the data storage base path for on-disk backends #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add methods `dataStorageBasePath()` and `dataStorageBasePath<-` for `MsBackend`, `MsBackendMzR` and `Spectra` to allow changing the base path to the data storage folder for on-disk backends (issue #321).
philouail
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On-disk backends depend on the (original) data files being available. Moving/copying serialized
Spectraobjects with such backends between file systems or moving the original data files will break their functionality.This PR adds a new method to the
MsBackend,dataStorageBasePath()anddataStorageBasePath<-to get or set the base path to the directory of the data storage files for on-disk backends (issue #321 ).