Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes of functions to method and move to ProtGenerics #345

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

philouail
Copy link
Collaborator

The functions changes are the following:

  • applyProcessing()
  • processingChunkFactor()
  • processingChunkSize() and processingChunkSize<-

It was done so they could be implemented in the Chromatograms package.

@philouail philouail requested a review from jorainer January 15, 2025 14:40
Copy link
Member

@jorainer jorainer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks Phili!

@jorainer jorainer merged commit 31ab50b into main Jan 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants