Add EFFECTIVENESS_SE for tests #7360
Open
+132
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 10, 2025 16:51
…s sound effects (surrogate for result)
…pansion into expansion/spreadmove
ghoulslash
added
the
category: battle-tests
AlexOn1ine
reviewed
Jul 18, 2025
| return gBattleStruct->moveResultFlags[battlerDef]; | ||
| } | ||
| } | ||
| if ((gBattleStruct->moveResultFlags[battlerDef] & MOVE_RESULT_NO_EFFECT // (MOVE_RESULT_MISSED | MOVE_RESULT_NO_EFFECT) |
There was a problem hiding this comment.
Comment probably not needed
There was a problem hiding this comment.
Actually is this correct? Do we want to include MOVE_RESULT_DOESNT_AFFECT_FOE here?
AlexOn1ine
reviewed
Jul 18, 2025
| // Only play the "best" sound | ||
| for (u32 sound = 0; sound < 3; sound++) | ||
| u32 battlerDef; | ||
| u32 ret = resultFlags; |
There was a problem hiding this comment.
Suggested change
| u32 ret = resultFlags; | |
| u32 resultFlagsForSoundEffectiveness = resultFlags; |
Doesn't have to be this verbose but maybe something more expressive? It's not clear from ret what we are returning without reading the code fully.
|
Build fails |
|
Please merge current master into this PR, there's been an issue with the test runner that made some tests not run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds effectiveness sound effect check in tests to support spread move tests