You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing comments here instead of in the unscrollable pile of bin files. NavelRock_Base missing in this PR, it's present under the name NavelRock_Bottom_Frlg.
Does PalletTown_PlayerHouse_#F need to be added with the _Frlg suffix? It's not present in Emerald.
RustburoCity_Flat1_1F is the same in both repos, but you could argue that it should be present with the _Frlg suffix since the other RustburoCity_Flat#_#F needs the suffix.
I think that maybe all of the FRLG safari zone layouts should have the _Frlg suffix, and I guess the same should apply to maps:
Safari Zone
Navel Rock
Victory Road
Should the FRLG maps have more than the scripts in them?
aide.inc, bag_full.inc, pokedex_rating.inc, pokemon_league.inc, pokemon_mansion.inc, seagallop.inc, static_pokemon.inc and trainer_tower.inc, seem to be missing, and I think that the scripts in them are still called by some of the included scripts.
GeneralDoesn't fit under other labelstype: big featureA feature with big diffs and / or high impact / subjectivity / pervasiveness
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hedara90
added
General
Description
Adds map data/scripts/tilesets. Shouldn't change the build for now.
Discord contact info
.cawt