Update fishing odds to match official games #7574
Open
+53
−135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No complaints with the code. Can you provide evidence of it working? If you look at my Verified Scenarios, showing the game with terminal output would be awesome. |
|
Demo video was too big for github, I posted it on: |
kittenchilly
suggested changes
Aug 21, 2025
Update gen1 hook chance to 50% for good rod Update gen2 hook chance to be 50% for all rods I can't read the disassembly to figure out the good rod/super rod chances for gen 1 and 2 but i will trust kittenchilly on this one. Co-authored-by: kittenchilly <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fishing odds code has been refactored to be simpler to understand and better match official games
Fishing odds now uses RNG tags, and the game now computes the odds of cataching a fish instead of the odds of not catching one (this doesn't change behavior but makes the code easier to read)
Gen 1-2 Good Rod chance updated from 67% to 33% (this is the correct value according to the bulbapedia fishing page, Ia m unable to read the disassembly to check)
Sticky Hold/Suctions Cup code has been changed to double biting odds post gen4 and give another 85 percent roll in pre gen 4
Added option to increase bite chance in morning and evening just like in XY
Changed proximity boost to match behavior described in this youtube video: the game checks the three tiles adjacent to the bobber tile where the player is not and I add a 20% boost if that tile is not surfable/fishable water
Description
Media
Issue(s) that this PR fixes
Fixes #7459
Things to note in the release changelog:
Discord contact info
Jamie (foster_harmony)