Fixed Ball Fetch Ability #7764
Merged
Fixed Ball Fetch Ability #7764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typo fix
Ball Fetch updated to activate correctly in battle. Ball Fetch tests added.
AlexOn1ine
added
category: battle-mechanic
gLastUsedBall increased to u16 to fix overflow. gBattleResults.CatchAttempts set to use ItemIdToBallId like it's supposed to. Strange Ball exceptions removed since the above two were fixed.
AlexOn1ine
approved these changes
Sep 21, 2025
FosterProgramming
pushed a commit
to FosterProgramming/pokeemerald-expansion
that referenced
this pull request
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Ball Fetch which wasn't activating in battle. Added related test cases.
Description
Ball Fetch logic was altering the BallID for some reason which caused it to not read the right used ball. Removed that, rearranged the logic a little to get the held item to update right, then added test cases.
Discord contact info
bassforte